Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated interfaces #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JensAyton
Copy link
Contributor

This has been deprecated for over two years.

If we merge this it’s a semver MAJOR change, so I guess the question is if we want anything else in a 2.0.0 release.

@rastersize @8W9aG @dflems

@codecov-io
Copy link

Codecov Report

Merging #103 into master will decrease coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   99.27%   98.94%   -0.33%     
==========================================
  Files          14       14              
  Lines         964      952      -12     
==========================================
- Hits          957      942      -15     
- Misses          7       10       +3
Impacted Files Coverage Δ
Sources/SPTPersistentCacheOptions.m 100% <ø> (ø) ⬆️
Sources/SPTPersistentCache.m 99.05% <0%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89236fc...4b37534. Read the comment docs.

Copy link
Contributor

@8W9aG 8W9aG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can bump the semver here, nothing else I would like to add in

@dflems
Copy link
Contributor

dflems commented Aug 13, 2018

Looking through the internal bug tracker, we don't seem to have any open tickets. Maybe we could do some of the smaller feature requests.

@dflems
Copy link
Contributor

dflems commented Jan 3, 2019

@JensAyton: I just got this project happy with Xcode 10 if you care to revive this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants