Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove roxygen2 in Suggests #31

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Remove roxygen2 in Suggests #31

merged 1 commit into from
Dec 6, 2023

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Dec 6, 2023

Hi roxygen2 is not a runtime dependency. It means you don't need it in Suggests.

You declare your dependency on roxygen2 with the roxygenNote field.

https://roxygen2.r-lib.org/articles/roxygen2.html

See https://r-pkgs.org/man.html for reference too

The Maintainer field is irrelevant too as all info is in Authors@R :)

Signed-off-by: olivroy <[email protected]>
Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sporty-r ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 1:07pm

Copy link

sweep-ai bot commented Dec 6, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@rossdrucker rossdrucker self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50153a4) 99.90% compared to head (6c05b82) 99.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          25       25           
  Lines        8410     8410           
=======================================
  Hits         8402     8402           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rossdrucker rossdrucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates here, all looks good to me. Appreciate the help cleaning this up!

@rossdrucker rossdrucker merged commit c1fb589 into sportsdataverse:main Dec 6, 2023
12 checks passed
@olivroy olivroy deleted the patch-1 branch December 6, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants