CSPL-3256 - Support to configure deployer resource spec in SHC CRD #1419
+250
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration test run which tests the deployer spec resources here. PFA the log with the TC from the PR. |
rlieberman-splunk
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the SHC CRD deploys both the SHC as well as the deployer. The common resource spec here applies to both of them if configured.
However, the deployer requires significantly less resources. The MR here adds support to explicitly add resource spec config capability(for deployer) within the SHC CRD. The common spec config will apply by default and is overridden by the deployer spec for the deployer statefulset if configured.