Cspl-2489: GITHUG-1153 - Fix indexer deletion in upgrade scenario #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav-splunk
approved these changes
Oct 5, 2023
akondur
reviewed
Oct 5, 2023
akondur
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR test GITHUT -1153 issue
addresses issue #1151.
There are 2 changes:
Make sure that the fix of PR #1041 is applied in the cluster-manager usecase
Fix the check on the image version. The format of the image field being like splunk/splunk-operator:8.2.0, it is needed to get the version that is after the colon. The previous check was only checking if the image was starting with 8 or 9, which is always false.