Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/deployment pvc #1223

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Fix/deployment pvc #1223

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1b7473c
Fix malformed deployment when set storageClassName.
mvleandro Aug 22, 2023
c9768da
Changing check before add storageClassName.
mvleandro Aug 22, 2023
5027171
Removing check before add storageClassName setting default.
mvleandro Aug 22, 2023
9cb779d
Testing a new approach.
mvleandro Aug 22, 2023
ea75bb6
Adding conditional for storageClassName.
mvleandro Aug 22, 2023
2518846
Increasing chart version.
mvleandro Aug 22, 2023
fe10865
Removing dependency from splunk-operator.
mvleandro Aug 31, 2023
9ae34fb
Adding conditional.
mvleandro Aug 31, 2023
e082f9c
Removing conditional.
mvleandro Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helm-chart/splunk-operator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: "2.3.0"
version: "2.3.1"

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "2.3.0"
appVersion: "2.3.0"
4 changes: 2 additions & 2 deletions helm-chart/splunk-operator/templates/app_download.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ spec:
storage: 10Gi
{{- end }}
volumeMode: Filesystem
{{- if $volume.storageClassName }}
storageClassName: {{ $volume.storageClassName }}
{{- if $.Values.splunkOperator.persistentVolumeClaim.storageClassName }}
storageClassName: {{ $.Values.splunkOperator.persistentVolumeClaim.storageClassName }}
{{- end }}

---
Expand Down
4 changes: 4 additions & 0 deletions helm-chart/splunk-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ splunkOperator:
# reference: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.20/#pod-v1-core
terminationGracePeriodSeconds: 10

# Set storageClassName for the PersistentVolumeClaim
persistentVolumeClaim:
storageClassName: "default"

# Specify volumes for Splunk Operator pod, append additional volumes to list
# reference: https://kubernetes.io/docs/concepts/storage/volumes/
volumes:
Expand Down