adding keras_preprocessing dependency for DGA detection #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dglauche thanks for flagging this. Since version 5.1.1 we tried to move all ESCU related content into a dedicated image. I also think we forced a specific tensorflow version to avoid this issue with keras_preprocessing which was reported a few times. Did you try to run the DGA detection with the ESCU image ? This would be the preferred way. Happy to explore to add keras_preprocessing to the golden image, but I would avoid it for the minimal one as this was designed to give a minimal starting point to derive others. Kindly let me know your thoughts. Many thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keras_preprocessing is needed for the prebuilt DGA detection