Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:New Enterprise version #2656

Draft
wants to merge 8 commits into
base: enterprise/next
Choose a base branch
from
Draft

feat:New Enterprise version #2656

wants to merge 8 commits into from
+14,871 −3

Conversation

rjha-splunk
Copy link
Collaborator

Enterprise version Intitial Draft

@rjha-splunk rjha-splunk deleted the enterprise_beta branch December 18, 2024 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
@rjha-splunk rjha-splunk reopened this Dec 18, 2024
mbukowski-splunk
mbukowski-splunk approved these changes Dec 18, 2024
View reviewed changes
package/enterprise/etc/conf.d/conflib/app-lp_dest_archive/plugin.py
for vn, vv in os.environ.items():
m = re.search(regexfa, vn)

r = m.group(1) if m else ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that line exists in multiple files, I would suggest scan it with sonarqube code duplication and address in separate story.

ikheifets-splunk
ikheifets-splunk approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@ikheifets-splunk ikheifets-splunk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! We had a discussion with Rahul about is it should be a enterprise branch in repo or just a copy-paste enterprise folder. As I understand the next enterprise release would have a completely another approach and architecture.

cc @mstopa-splunk

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ikheifets-splunk ikheifets-splunk ikheifets-splunk approved these changes

@mbukowski-splunk mbukowski-splunk mbukowski-splunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjha-splunk @mbukowski-splunk @ikheifets-splunk