fix: refactor create query #1140
Merged
+89
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajasnosz
changed the title
ajasnosz
force-pushed
the
fix/refactor-create-query
branch
from
d6da58b to
24b09ba
Compare
ikheifets-splunk
approved these changes
Dec 18, 2024
| "in": "$in", | ||
| "regex": "$regex", | ||
| } | ||
| def convert_to_float(value: typing.Any, ignore_error: bool = False) -> typing.Any: |
There was a problem hiding this comment.
probably we can group this function and human_bool to separate module
|
🎉 This PR is included in version 1.12.1-beta.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor of create query
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
manual, unit, integration
Checklist