Fix: refactor gather elements

[ajasnosz]

Description

Refactor of gather_elements() method.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Refactor/improvement

How Has This Been Tested?

manual, unit, integration

Checklist

• My commit message is conventional
• I have run pre-commit on all files before creating the PR
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have checked my code and corrected any misspellings

[ikheifets-splunk]

probably better would be name it merge_profiles_*, because you we have active_profiles that mutable variable and it's super unclear that we modifying it inside function and after that using it on top level.

It seems this peace of code we using on both functions (super similar) can we reuse it? And I think merge_profiles would be good name for this method.

  for key, profile in profiles.items():
         if key in active_profiles:
             if not profile.get("enabled", True):
                 celery_logger.info(f"disabling profile {key}")
                 del active_profiles[key]
             else:
                 active_profiles[key] = profile
         else:
             active_profiles[key] = profile

P.S. If dangerous to touch this code we can stay with current approach

[ajasnosz]

I've extracted the common part to new method, but I wouldn't try to merge them into one

[srv-rr-github-token]

🎉 This PR is included in version 1.12.1-beta.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀