fix: allow * in profile (#151)

splunk · Oct 14, 2021 · 880dbce · 880dbce
1 parent 7bdb37c
commit 880dbce
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/splunk_connect_for_snmp_poller/manager/tasks.py b/splunk_connect_for_snmp_poller/manager/tasks.py
@@ -85,7 +85,7 @@ async def get_snmp_data(
                 var_binds,
             )
         except Exception as e:
-            logger.error(f"Error occurred while calling {handler.__name__}(): {e}")
+            logger.exception(f"Error occurred while calling {handler.__name__}(): {e}")
 
 
 def sort_varbinds(varbind_list: list) -> VarbindCollection:

diff --git a/splunk_connect_for_snmp_poller/manager/validator/inventory_validator.py b/splunk_connect_for_snmp_poller/manager/validator/inventory_validator.py
@@ -38,6 +38,8 @@
 
 profile_pattern = re.compile("^[A-Za-z0-9_-]*$")
 
+DYNAMIC_PROFILE = "*"
+
 SNMP_VERSION_1 = "1"
 SNMP_VERSION_2C = "2c"
 SNMP_VERSION_3 = "3"
@@ -114,7 +116,7 @@ def is_valid_community(community_string):
 
 
 def is_valid_profile(profile):
-    return profile_pattern.match(profile.strip())
+    return profile == DYNAMIC_PROFILE or profile_pattern.match(profile.strip())
 
 
 def is_valid_inventory_line_from_dict(host, version, community, profile, seconds):

diff --git a/tests/test_inventory_validator.py b/tests/test_inventory_validator.py
@@ -68,3 +68,4 @@ def test_invalid_profile_name(self):
         self.assertFalse(is_valid_profile("asd sa"))
         self.assertFalse(is_valid_profile("&asd"))
         self.assertTrue(is_valid_profile("1_asd-asds"))
+        self.assertTrue(is_valid_profile("*"))