Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

fix: broken MIB translation unit tests #34

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

lstoppa
Copy link
Contributor

@lstoppa lstoppa commented Jun 7, 2021

  • config.yaml wasn't properly loaded (need to look to the parent's folder)

- config.yaml wasn't properly loaded (need to look to the parent's folder)
@lstoppa lstoppa requested a review from ryanfaircloth as a code owner June 7, 2021 11:32
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@975c556). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage        ?   96.67%           
=======================================
  Files           ?       25           
  Lines           ?     4545           
  Branches        ?        0           
=======================================
  Hits            ?     4394           
  Misses          ?      151           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975c556...81c8d42. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2021

Expected release notes (by @lstoppa)

fixes:
fixed isort, flake8 (part #3) (81c8d42)
fixed isort, flake8 (part #2) (94b34a1)
fixed isort, flake8 (3beb7f8)
fixed isort, pylint checker (227a018)
broken MIB translation unit tests (use relative paths) - tested locally that now poetry run pytest works as expected (45d1b73)
broken MIB translation unit tests (use relative paths) (516f449)
broken MIB translation unit tests (added a copy of the config file) (5345f62)
broken MIB translation unit tests - config.yaml wasn't properly loaded (need to look to the parent's folder) (07ba576)
correct image path (975c556)

others (will not be included in Semantic-Release notes):
move to actions (#33) (03afb42)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

Sorry, something went wrong.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants