Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Helm3 Datasource #299

Closed
wants to merge 1 commit into from
Closed

Conversation

michael-burt
Copy link
Collaborator

This PR mirrors @gotwarlost #265

@michael-burt michael-burt changed the base branch from helm3 to main August 24, 2023 17:54
@michael-burt michael-burt changed the title Draft: Implement Helm3 Datasource Implement Helm3 Datasource Aug 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #299 (a1f8957) into main (678dad0) will decrease coverage by 0.57%.
Report is 1 commits behind head on main.
The diff coverage is 52.63%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   73.80%   73.24%   -0.57%     
==========================================
  Files          73       74       +1     
  Lines        7021     7210     +189     
==========================================
+ Hits         5182     5281      +99     
- Misses       1622     1701      +79     
- Partials      217      228      +11     
Files Changed Coverage Δ
internal/remote/patch.go 0.00% <ø> (ø)
vm/internal/ds/factory/datasource.go 82.14% <0.00%> (-9.86%) ⬇️
vm/internal/importers/data-source.go 100.00% <ø> (ø)
vm/internal/importers/glob.go 96.51% <ø> (ø)
vm/internal/ds/helm3/helm3.go 53.22% <53.22%> (ø)
vm/internal/ds/exec/exec.go 100.00% <100.00%> (ø)

Copy link

github-actions bot commented Jan 21, 2024

CLA Assistant Lite bot: All contributors have NOT signed the COC Document


I have read the Code of Conduct and I hereby accept the Terms


You can retrigger this bot by commenting recheck in this Pull Request

@michael-burt michael-burt force-pushed the helm3 branch 2 times, most recently from 04cf7f7 to 029ad0c Compare January 21, 2024 18:35
@michael-burt
Copy link
Collaborator Author

recheck

@michael-burt
Copy link
Collaborator Author

recheck

@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
@michael-burt michael-burt deleted the helm3 branch November 27, 2024 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants