-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contentctl 5 #334
Open
pyth0n1c
wants to merge
50
commits into
main
Choose a base branch
from
contentctl_5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
contentctl 5 #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that was accidentally dropped. set extra='forbid' for SecurityContentObject
… should not be in the yml
to computed_field
field for investigation
pydantic object definitions.
new template. Added drilldowns, if appropriate, and made the link to attack_data set invalid, so that if it is not updated it fails validation. This prevents an incorrect attack_data from failing silently.
temporarily, to test against relevant updated content
repo reference
Bump version of contentctl to v4.5.0 in prep for release.
repeatable value when a field has not been updated. Provide more context for enum fields as to what can be set. Finally, throw an error during YML read if an un-UPDATED field still exists in any of the YMLs.
Remove extra pair of quotes from new detection template
version to resolve bug in our code
multiple inheritance, to StrEnum or IntEnum
However, this has not received any testing yet.
now that they have been more strictly defined as IntEnum or StrEnum. This has not yet been tested.
…StrEnum and IntEnum when writing YMLs from objects that contain them.
new_content.py
Exception on extra fields
that restated it. but this is not necessary if they inherit from SecurityContentObject
Python 3.13 support use_enum_values is also slated for removal in the target branch
Remove use enum values
GH Actions Matrix update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contentctl 5 will contain a number of changes.
Instead of targeting PRs at main, they will be targeted at this branch