refactor: introduce parameters to control argo environment #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbruzda-splunk
force-pushed
the
feat/argo_parameters
branch
from
fa50573 to
ad973cb
Compare
mkolasinski-splunk
requested changes
Feb 20, 2024
kdoroszko-splunk
approved these changes
Feb 20, 2024
mbruzda-splunk
requested review from
mkolasinski-splunk and
kdoroszko-splunk
mkolasinski-splunk
approved these changes
Feb 21, 2024
|
I can see some issue in Backwards compatibility test run: https://github.com/splunk/splunk-add-on-for-cisco-meraki/actions/runs/7975941038/job/21775546947?pr=457 |
Yes, this was an old run. I updated the link to where it is fixed |
artemrys
approved these changes
Feb 21, 2024
|
🎉 This PR is included in version 4.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parameters to simplify the process of making changes and testing argo related stuff
Tested here:
https://github.com/splunk/splunk-add-on-for-cisco-meraki/actions/runs/7979596198 Backwards compatibility
https://github.com/splunk/splunk-add-on-for-okta-identity-cloud/actions/runs/7986170413/job/21806162151 staging