Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove escu tests from reusable workflow #234

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

mkolasinski-splunk
Copy link
Contributor

@mkolasinski-splunk mkolasinski-splunk commented Feb 15, 2024

PR removes ESCU tests execution from reusable workflow.
Currently ESCU tests are not working, and due to lack of test data it is not possible to execute them properly.

Test runs:
https://github.com/splunk/splunk-add-on-for-google-workspace/pull/542
https://github.com/splunk/splunk-add-on-for-microsoft-sysmon/pull/313

@mkolasinski-splunk mkolasinski-splunk marked this pull request as ready for review February 15, 2024 09:38
@mkolasinski-splunk mkolasinski-splunk requested a review from a team as a code owner February 15, 2024 09:38
@artemrys
Copy link
Member

Do we need to update documentation as well?

@kdoroszko-splunk
Copy link
Contributor

Should we make a test run before merge?

@mkolasinski-splunk mkolasinski-splunk force-pushed the feat/remove-escu-from-reusable-workflow branch from a18c97d to d06c016 Compare March 28, 2024 09:37
@mkolasinski-splunk mkolasinski-splunk merged commit 6dd311b into develop Mar 29, 2024
6 checks passed
@mkolasinski-splunk mkolasinski-splunk deleted the feat/remove-escu-from-reusable-workflow branch March 29, 2024 10:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
@srv-rr-github-token
Copy link

🎉 This PR is included in version 4.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants