Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove artifact-registry #226

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Conversation

artemrys
Copy link
Member

This PR removes artifact-registry step from the pipeline as we don't need Docker containers with add-on builds in the ghcr.io. It is not used in the infra anywhere. Also clean up README.md.

Test run: https://github.com/splunk/splunk-add-on-for-mysql/actions/runs/7669490177

@mkolasinski-splunk
Copy link
Contributor

I think in existing @ajanus-splunk compatibility pipeline TA build is being downloaded from artifacts related with given workflow execution.
Worth confirming and taking under consideration when designing new solution

@artemrys
Copy link
Member Author

artemrys commented Feb 7, 2024

I think in existing @ajanus-splunk compatibility pipeline TA build is being downloaded from artifacts related with given workflow execution. Worth confirming and taking under consideration when designing new solution

I don't think we are breaking this contract, artifact-registry uploads to GitHub Registry, not as workflow's artifact.

@kdoroszko-splunk
Copy link
Contributor

I think we could also remove images/artifacts_all.png file and images/modinput/ directory.

@artemrys
Copy link
Member Author

artemrys commented Feb 7, 2024

I think we could also remove images/artifacts_all.png file and images/modinput/ directory.

Let's do!

@artemrys artemrys merged commit a841385 into develop Feb 8, 2024
6 checks passed
@artemrys artemrys deleted the fix/remove-artifact-registry branch February 8, 2024 14:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
@srv-rr-github-token
Copy link

🎉 This PR is included in version 4.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants