Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: skip fossa if there are no main deps for poetry #216

Closed
wants to merge 10 commits into from
Closed

Fix: skip fossa if there are no main deps for poetry #216

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fd70f3b
fix: remove dev dependencies from fossa scan
mbruzda-splunk Jan 11, 2024
54bad43
fix: install crudini using apt
mbruzda-splunk Jan 11, 2024
6447fd2
fix: sudo apt
mbruzda-splunk Jan 11, 2024
25c57a8
chore: remove debug prints
mbruzda-splunk Jan 11, 2024
47fe9fa
chore: use pip to install crudini
mbruzda-splunk Jan 11, 2024
88635c3
fix: skip fossa with no main deps
mbruzda-splunk Jan 15, 2024
494735b
chore: fix path to setup python job
mbruzda-splunk Jan 15, 2024
85f0e48
chore: fix path to setup python job
mbruzda-splunk Jan 15, 2024
7957efe
chore: move check dependencies code to fossa-scan job
mbruzda-splunk Jan 15, 2024
17fa968
chore: env variables should now work
mbruzda-splunk Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/reusable-build-test-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,7 @@ jobs:
- uses: actions/setup-python@v5
- name: remove dev dependencies
run: |
sudo apt install crudini
pip install poetry==1.5.1
pip3 install crudini poetry==1.5.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a PR with the logic - let's not run fossa if there is no main dependencies.

I'll talk to Andrzej and we will get an approval for that from legal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artemrys I reworked the PR. I didn't handle THIRDPARTY file as we are waiting for the decision from legal team

crudini --del pyproject.toml tool.poetry.group.dev.dependencies
poetry lock --no-update
- name: run fossa anlyze and create report
Expand Down
Loading