Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: semgrep job update #213

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Conversation

kdoroszko-splunk
Copy link
Contributor

@kdoroszko-splunk kdoroszko-splunk commented Jan 5, 2024

This PR update semgrep job in the reusable-build-test-release.ym.
The change was necessary, because previously used semgrep-action was deprecated.

Jira: https://splunk.atlassian.net/browse/ADDON-67642

Tested on: https://github.com/splunk/test-addonfactory-repo/actions/runs/7421872771/job/20196096465

@kdoroszko-splunk kdoroszko-splunk requested a review from a team as a code owner January 5, 2024 12:48
Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather call it a refactor than chore. We don't change the functionality, chore is mostly for cleanups.

We also need to update the documentation in README.md file.

@kdoroszko-splunk kdoroszko-splunk changed the title chore: semgrep job update refactor: semgrep job update Jan 5, 2024
Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kdoroszko-splunk kdoroszko-splunk merged commit 30976db into develop Jan 5, 2024
6 checks passed
@kdoroszko-splunk kdoroszko-splunk deleted the chore/semgrep_update branch January 5, 2024 13:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants