Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use labels for test execution on PRs to main #208

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

awownysz-splunk
Copy link
Contributor

@awownysz-splunk awownysz-splunk commented Dec 27, 2023

Context

So far, PRs to main by default have all the tests enabled. Applying labels to enable particular tests is available only for PRs that are not to main.
Our team doesn't use develop branch, thus we need to be able to skip some tests on PRs to main - to get feedback quickly.

Summary of changes

  • This PR makes it possible to use labels for enabling/disabling tests also on PRs to main.
  • apart from test labels (execute_knowledge, etc.), use_labels label has to be applied to the PR before (re)opening it to make test labels work - this is to ensure that execution of all tests is still the default option for PRs to main

Sample CI/CD runs for PR

PR: https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/pull/993
Workflow runs:

@artemrys artemrys merged commit 3af5fd6 into main Dec 29, 2023
6 checks passed
@artemrys artemrys deleted the feat/test-labels-for-prs-to-main branch December 29, 2023 10:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
@srv-rr-github-token
Copy link

🎉 This PR is included in version 4.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants