Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce a lightweight workflow which utilizes composite actions #199

Merged
merged 5 commits into from
Dec 12, 2023
Merged

feat: introduce a lightweight workflow which utilizes composite actions #199

merged 5 commits into from
Dec 12, 2023

Conversation

awownysz-splunk
Copy link
Contributor

@awownysz-splunk awownysz-splunk commented Dec 4, 2023 •
edited by artemrys
Loading

This PR introduces a lightweight workflow to get faster feedback on PRs. The new approach utilizes composite actions to allow for separate definition of each job.

Based on the following MSCS TA Jira story: https://splunk.atlassian.net/browse/ADDON-66448?atlOrigin=eyJpIjoiYjc1NzdkNzc4MTlkNDM0ODg2M2EzZDY0YzgyNGZmMjMiLCJwIjoiaiJ9

Sample run of the reused workflow in the MSCS TA repo: https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/workflows/lightweight-check-pr.yml

@awownysz-splunk awownysz-splunk requested a review from a team as a code owner December 4, 2023 07:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited
Loading

CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@awownysz-splunk
Copy link
Contributor Author

I have read the CLA Document and I hereby accept the CLA

@awownysz-splunk
Copy link
Contributor Author

I have read the COC Document and I hereby accept the COC

@awownysz-splunk
Copy link
Contributor Author

I have read the Code of Conduct and I hereby accept the Terms

artemrys
artemrys reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awownysz-splunk Are you planning to reuse those actions in the main reusable workflow eventually?

@awownysz-splunk
Copy link
Contributor Author

awownysz-splunk commented Dec 5, 2023 •
edited
Loading

@awownysz-splunk Are you planning to reuse those actions in the main reusable workflow eventually?

Yes, that's the idea. I guess I can do this in one go - I'll update the PR then

@awownysz-splunk awownysz-splunk force-pushed the ci/lightweight-workflow-ADDON-66448 branch 2 times, most recently from d18dab1 to 92a1bd5 Compare December 6, 2023 13:10
@awownysz-splunk
Copy link
Contributor Author

awownysz-splunk commented Dec 6, 2023 •
edited
Loading

@artemrys reusable-build-test-release.yml is now refactored using Composite Actions that I've created for the lightweight workflow. You can see a successful workflow run here: https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/7103546362
Jobs for UI tests, etc. remain unchanged - I haven't implemented separate actions for them as they were not needed for the lightweight workflow. I guess refactoring this part would be a separate task.

@awownysz-splunk awownysz-splunk force-pushed the ci/lightweight-workflow-ADDON-66448 branch from 13affc5 to 3303c14 Compare December 8, 2023 13:38
@awownysz-splunk awownysz-splunk force-pushed the ci/lightweight-workflow-ADDON-66448 branch from 75218bd to a689ad5 Compare December 8, 2023 14:55
@awownysz-splunk awownysz-splunk force-pushed the ci/lightweight-workflow-ADDON-66448 branch 2 times, most recently from 6584468 to ab1f229 Compare December 8, 2023 15:47
@awownysz-splunk awownysz-splunk force-pushed the ci/lightweight-workflow-ADDON-66448 branch from c0c7a14 to 6c311de Compare December 12, 2023 10:51
@artemrys artemrys changed the title ci: introduce a lightweight workflow which utilizes composite actions feat: introduce a lightweight workflow which utilizes composite actions Dec 12, 2023
@artemrys
Copy link
Member

I am changing the PR to be a "feat" so we can have a release and you can properly reference it in your repo.

artemrys
artemrys approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@artemrys artemrys merged commit c954809 into main Dec 12, 2023
6 checks passed
@artemrys artemrys deleted the ci/lightweight-workflow-ADDON-66448 branch December 12, 2023 12:20
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
@srv-rr-github-token
Copy link

🎉 This PR is included in version 4.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@artemrys artemrys artemrys approved these changes

@mbruzda-splunk mbruzda-splunk Awaiting requested review from mbruzda-splunk mbruzda-splunk is a code owner automatically assigned from splunk/products-gdi-addons-adminrepo

@mkolasinski-splunk mkolasinski-splunk Awaiting requested review from mkolasinski-splunk

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awownysz-splunk @artemrys @srv-rr-github-token