feat: add CheckboxTree component #1495
Conversation
rohanm-crest
changed the title
rohanm-crest
force-pushed
the
feat/checkbox-tree-component
branch
from
7bacfa3 to
f23a4c0
Compare
ui/src/components/CheckboxTree/stories/CheckboxTree.stories.tsx
Outdated
Show resolved
Hide resolved
tests/testdata/test_addons/package_global_config_everything/globalConfig.json
Outdated
Show resolved
Hide resolved
ui/src/components/CheckboxTree/stories/CheckboxTree.stories.tsx
Outdated
Show resolved
Hide resolved
|
ahhh. miss-clicked into approval, unfortunately can't revoke it, pls address mentioned issues before proceeding. |
…unk/addonfactory-ucc-generator into feat/checkbox-tree-component
ui/src/components/table/stories/__images__/TableWrapper-ouath-basic-chromium.png
Outdated
Show resolved
Hide resolved
vtsvetkov-splunk
changed the title
…unk/addonfactory-ucc-generator into feat/checkbox-tree-component
| data-indeterminate={isIndeterminate} | ||
| onChange={() => handleParentCheckboxForGroup(group.label, !isParentChecked)} | ||
| disabled={disabled || group.options?.disabled} | ||
| aria-label="custom checkbox for group" |
There was a problem hiding this comment.
The label is not correct since it does not reflect the real meaning for that checkbox
There was a problem hiding this comment.
I would expect to see the explanation what is this checkbox for.
`Select all ${group.label}`
`Deselect all ${group.label}`
There was a problem hiding this comment.
In this, we have 3 state:
- select all
- deselect all
- indeterminate
but splunk don't have support for indeterminate, that's why I have added a custom checkbox so that we can use the upper 3 states for checkbox
| data-indeterminate={isIndeterminate} | ||
| onChange={() => handleParentCheckboxForGroup(group.label, !isParentChecked)} | ||
| disabled={disabled || group.options?.disabled} | ||
| aria-label="custom checkbox for group" |
There was a problem hiding this comment.
I would expect to see the explanation what is this checkbox for.
`Select all ${group.label}`
`Deselect all ${group.label}`
| prisma: variables.contentColorMuted, | ||
| })}; | ||
| } | ||
| `; |
There was a problem hiding this comment.
the amount of CSS we have to support and sync with splunk-ui, dark and light themes + enterprise, prisma and upcoming Magneto theme drives me crazy. And it is just for indeterminate view
There was a problem hiding this comment.
Yes, as splunk don't have support for indeterminate, we need that long CSS styling.
If we don't want this indeterminate feature, then we could remove this feature and also the long CSS. wdyt?
Issue number: ADDON-76198
PR Type
What kind of change does this PR introduce?
Summary
Changes
A new component
CheckboxTreehas been introduced to define hierarchical checkbox structures with support of search functionality.User experience
User can use the new component for handling the list of checkboxes with better UI including the expanding/collapsing, grouping and searching within the checkbox list.
Checklist
If an item doesn't apply to your changes, leave it unchecked.