Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: removed requests from solnlib's dependencies #412

Merged
merged 3 commits into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/release_6_0_0.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Removed requests from solnlib

The `requests` library has been removed from solnlib, so solnlib now depends on the `requests` library from the running environment.
By default, splunk delivers `requests` whose version depends on the splunk version. More information [here](https://docs.splunk.com/Documentation/Splunk/9.2.3/ReleaseNotes/Credits).
artemrys marked this conversation as resolved.
Show resolved Hide resolved

Please note that if `requests` are installed in `<Add-on>/lib` e.g. as a dependency of another library, that version will be taken first.
If `requests` are missing from the add-on's `lib` directory, then `requests` provided from splunk will be used. In case the splunk `requests` version is not sufficient for you,
you can deliver version you need by simply adding it to the `requirements.txt` or `pyproject.toml` file in your add-on.
1 change: 1 addition & 0 deletions mkdocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ plugins:

nav:
- Home: index.md
- Release 6.0.0: release_6_0_0.md
- References:
- modular_input:
- "checkpointer.py": modular_input/checkpointer.md
Expand Down
3 changes: 1 addition & 2 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ classifiers = [

[tool.poetry.dependencies]
python = ">=3.7,<3.14"
requests = "^2.31.0"
urllib3 = "<2"
artemrys marked this conversation as resolved.
Show resolved Hide resolved
sortedcontainers = ">=2"
defusedxml = ">=0.7"
Expand Down
Loading