Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(code): encode proxy username and password #143

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmoolya-crest
Copy link
Collaborator

JIRA: https://splunk.atlassian.net/browse/ADDON-57964

Proxy username and passwords have been encoded to accept (/,).

@codecov-commenter
Copy link

Codecov Report

Merging #143 (f4d7497) into main (655c6a0) will decrease coverage by 0.35%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   46.63%   46.27%   -0.36%     
==========================================
  Files          38       36       -2     
  Lines        2498     2472      -26     
==========================================
- Hits         1165     1144      -21     
+ Misses       1333     1328       -5     
Impacted Files Coverage Δ
cloudconnectlib/core/http.py 57.04% <20.00%> (-0.52%) ⬇️
cloudconnectlib/common/log.py
cloudconnectlib/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rmoolya-crest rmoolya-crest force-pushed the ADDON-57964-encode-proxy-username-password branch from f4d7497 to af2bb89 Compare November 21, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants