Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[composites] Reduce circulation when the parallel node policy is SuccessOnOne #440

Merged
merged 3 commits into from
Sep 3, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions py_trees/composites.py
Original file line number Diff line number Diff line change
Expand Up @@ -731,14 +731,12 @@ def tick(self) -> typing.Iterator[behaviour.Behaviour]:
new_status = common.Status.SUCCESS
self.current_child = self.children[-1]
elif type(self.policy) is common.ParallelPolicy.SuccessOnOne:
successful = [
child
for child in self.children
if child.status == common.Status.SUCCESS
]
if successful:
new_status = common.Status.SUCCESS
self.current_child = successful[-1]
for index in range(len(self.children) - 1, -1, -1):
child = self.children[index]
starrye marked this conversation as resolved.
Show resolved Hide resolved
if child.status == common.Status.SUCCESS:
new_status = common.Status.SUCCESS
self.current_child = child
break
elif type(self.policy) is common.ParallelPolicy.SuccessOnSelected:
if all(
[c.status == common.Status.SUCCESS for c in self.policy.children]
Expand Down