Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[display] fix render Chinese #438

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

Darley-Wey
Copy link

No description provided.

@Darley-Wey Darley-Wey closed this Mar 12, 2024
@Darley-Wey
Copy link
Author

fix#437

@Darley-Wey Darley-Wey reopened this Mar 12, 2024
Copy link
Collaborator

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? I thought in Python 3, the "utf-8" encoding was default?

Anyways, maybe the best bet would be to modify this function with an encoding argument and default it to None, which is the default in the underlying functions being called:

@stonier
Copy link
Member

stonier commented Nov 25, 2024

Anyways, maybe the best bet would be to modify this function with an encoding argument and default it to None, which is the default in the underlying functions being called:

https://github.com/pydot/pydot/blob/39bd465c037344429886efda19d23ff16070858d/src/pydot/core.py#L1709C13-L1709C66
https://docs.python.org/3/library/functions.html#open

+1 to this. We might want to run through the uses of it and set it to utf-8 where it's used in demos and examples here though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants