Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email password signup #33

Open
wants to merge 6 commits into
base: create-unlink-hive-account-endpoint
Choose a base branch
from
Open

Email password signup #33

wants to merge 6 commits into from

Conversation

sisygoboom
Copy link
Collaborator

  • create email and password registration, along with tests and a dto for validation
  • made sub completely optional, its now more like email address only used to find accounts, not for authentication
  • did some refactoring, particularly in regard to hive username validation
  • moved uniqueness validation for USB and email to the datalayer

vaultec81
vaultec81 reviewed Jul 31, 2024
View reviewed changes
src/services/auth/auth.service.ts
});
try {
await this.legacyUserRepository.createNewEmailUser({ email, user_id });
return await this.legacyUserAccountRepository.createNewEmailAndPasswordUser({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you are doing this already, but the account shouldn't be active until the registration is completed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some changes to support this and its raised a question further down the pr

sisygoboom
sisygoboom commented Jul 31, 2024
View reviewed changes
src/services/auth/auth.service.ts

await this.emailService.sendRegistration(email, email_code);

return { access_token: this.jwtSign({ network: 'email', user_id }) };
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaultec81 so you don't want them to have an access token til they verify their email?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaultec81 vaultec81 vaultec81 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sisygoboom @vaultec81