Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipeline executions/orca): attribue to explicitly skip the outputs section in Deployment Manifest or Run Job stage #4032

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nirmalyasen
Copy link

@Nirmalyasen Nirmalyasen commented Dec 22, 2020

Most K8S deployments do not use the outputs in downstream stages. So, if it is not used
users can skip the output of the Deployment Manifest and Run Job (Manifest) stage by
specifiying the attribute noOutput set to false in the stage json.

This significantly reduces the execution context being saved in redis/databse or
sent to the browser.r.

This attempts to address the issues mentioned in
spinnaker/spinnaker#6159
spinnaker/spinnaker#6159

The issue is compounded when there is a nesting of pipelines and the manifests are duplicated many times over in the execution context. There is one PR (#3989) that also attempts to address the issue. It tries to do it at the pipeline stage. This PR attempts to apply the same fix but in a much more narrower scope - in Deploy Manifest and Run Job (Manifest) stages. One advantage of this is that it not only reduces the payload of the pipeline stages, but also of Deploy Manifest and Run Job stages. Hence overall it further reduces the data saved in redis/database as well as the amount of data transferred to the browser.

… if it is not used

users can skip the output of the Deployment Manifest and Run Job (Manifest) stage by
specifiying the attribute noOutput set to false in the stage json.

This significantly reduces the execution context being saved in redis/databse or
sent to the browser.
@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • d33c26a: Most K8S deployments do not use the outputs in downstream stages. So, if it is not used

  • 2328eaf: attribue to skip the outputs section in Deployment Manifest or Run Job stage

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@Nirmalyasen Nirmalyasen changed the title <fix> attribue to skip the outputs section in Deployment Manifest or Run Job stage feat(pipeline executions/orca): attribue to explicitly skip the outputs section in Deployment Manifest or Run Job stage Dec 22, 2020
…Deployment Manifest or Run Job stage

Most K8S deployments do not use the outputs in downstream stages. So, if it is not used
users can skip the output of the Deployment Manifest and Run Job (Manifest) stage by
specifiying the attribute noOutput set to false in the stage json.

This significantly reduces the execution context being saved in redis/databse or
sent to the browser.
@austinthao5
Copy link
Contributor

I forked your fix to my own repo to fix the PR Status Checks
#4242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants