Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(retrofit): Replace the RetrofitExceptionHandler with SpinnakerServerExceptionHandler #1034

Closed
wants to merge 1 commit into from

Conversation

j-sandy
Copy link
Contributor

@j-sandy j-sandy commented May 15, 2024

As RetrofitExceptionHandler have been dismantled from orca, now replacing it with SpinnakerServerExceptionHandler.

Copy link
Contributor

@dbyron-sf dbyron-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add SpinnakerServerExceptionHandler in one step, then tag/bump orca, then remove RetrofitExceptionHandler in a subsequent step.

…erServerExceptionHandler

As RetrofitExceptionHandler have been dismantled from [orca](spinnaker/orca#4716), now replacing it with SpinnakerServerExceptionHandler.
@dbyron-sf
Copy link
Contributor

Included in #1036

@dbyron-sf dbyron-sf closed this May 15, 2024
@j-sandy j-sandy deleted the retrofitexception branch May 16, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants