refactor(retrofit2): replace retrofit client with retrofit2 client #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Dec 4, 2024
fiat-api/src/main/java/com/netflix/spinnaker/fiat/shared/FiatAuthenticationConfig.java
Show resolved
Hide resolved
dbyron-sf
reviewed
Dec 4, 2024
fiat-api/src/main/java/com/netflix/spinnaker/fiat/shared/FiatService.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Dec 4, 2024
fiat-api/src/test/groovy/com/netflix/spinnaker/fiat/shared/FiatSharedSpecification.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Dec 4, 2024
fiat-api/src/test/groovy/com/netflix/spinnaker/fiat/shared/FiatSharedSpecification.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Dec 4, 2024
fiat-web/src/main/java/com/netflix/spinnaker/fiat/config/RetrofitConfig.java
Show resolved
Hide resolved
|
https://github.com/kirangodishala/fiat/blob/152eaeead5c9d745640e36831ee696075e08e6f2/fiat-roles/src/main/resources/resilience4j-defaults.properties#L30 still mentions RetrofitError. I figure that needs to change to SpinnakerServerException. It'd be great to have a test that fails without that though. |
This was referenced Dec 6, 2024
Closed
dbyron-sf
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of retrofit 2.x client in place of retrofit 1.9 and make required changes accordingly.
All the retrofit1 dependencies and references are removed.
Retrofit2 boilerplate code was already implemented in kork's kork-retrofit module and this PR makes use of it.
The
fiat-apimodule is being used in multiple Spinnaker services and the following services are impacted by this PR. Respective changes will be dealt in the subsequent PRs.