feat(build): add echo-integration module to exercise the just-built docker image #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to match what github actions uses
to facilitate testing container startup
…ocker image @W-15161670
…t.enabled
to fix:
Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
2024-03-29 03:19:26.437 ERROR 1 --- [ main] o.s.b.d.LoggingFailureAnalysisReporter :
***************************
APPLICATION FAILED TO START
***************************
Description:
Failed to bind properties under 'services.fiat.enabled' to boolean:
Property: services.fiat.enabled
Value: "${services.fiat.enabled:false}"
Origin: "services.fiat.enabled" from property source "Config resource 'class path resource [echo.yml]' via location 'optional:classpath:/' (document #0)"
Reason: java.lang.IllegalArgumentException: Circular placeholder reference 'services.fiat.enabled:false' in property definitions
Action:
Update your application's configuration
…t.baseUrl
to fix:
Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
2024-03-29 15:14:51.086 ERROR 1 --- [ main] o.s.b.d.LoggingFailureAnalysisReporter :
***************************
APPLICATION FAILED TO START
***************************
Description:
Failed to bind properties under 'services.fiat.base-url' to java.lang.String:
Property: services.fiat.base-url
Value: "${services.fiat.baseUrl:http://localhost:8089}"
Origin: "services.fiat.baseUrl" from property source "Config resource 'class path resource [echo.yml]' via location 'optional:classpath:/' (document #0)"
Reason: java.lang.IllegalArgumentException: Circular placeholder reference 'services.fiat.baseUrl:http://localhost:8089' in property definitions
Action:
Update your application's configuration
Use port 7003 since that's the default port for fiat from https://spinnaker.io/docs/reference/architecture/microservices-overview/#port-mappings.
with spring.config.activate.on-profile to remove these warnings: 2024-03-29 03:19:11.785 WARN 1 --- [ main] o.s.b.c.config.ConfigDataEnvironment : Property 'spring.profiles' imported from location 'class path resource [echo.yml]' is invalid and should be replaced with 'spring.config.activate.on-profile' [origin: class path resource [echo.yml] - 74:13] 2024-03-29 03:19:11.785 WARN 1 --- [ main] o.s.b.c.config.ConfigDataEnvironment : Property 'spring.profiles' imported from location 'class path resource [echo.yml]' is invalid and should be replaced with 'spring.config.activate.on-profile' [origin: class path resource [echo.yml] - 65:13] See https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-Config-Data-Migration-Guide#profile-specific-documents.
multi-arch with --load doesn't work, so add a separate step using the local platform to make an image available for testing. see docker/buildx#59
jasonmcintosh
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a healthcheck to the docker images, and a few other small cleanups