Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize frontend API endpoints and update with versioned apis #493

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Centralize frontend API endpoints and update with versioned apis #493

merged 6 commits into from
Sep 17, 2024

Conversation

mamy-CS
Copy link
Collaborator

@mamy-CS mamy-CS commented Sep 10, 2024 •
edited
Loading

Update Frontend to use Tornjak v1 API

@mamy-CS mamy-CS self-assigned this Sep 10, 2024
@mamy-CS mamy-CS linked an issue Sep 10, 2024 that may be closed by this pull request
Update Frontend to use Tornjak v1 API #492
Closed
@mamy-CS mamy-CS added this to the 1.9.0 milestone Sep 10, 2024
@mamy-CS mamy-CS added enhancement New feature or request frontend Tornjak UI (Frontend) labels Sep 10, 2024
maia-iyer
maia-iyer reviewed Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello just one comment: I think a different method is necessary? Let me know if that's incorrect

frontend/src/components/tornjak-api-helpers.tsx Outdated Show resolved Hide resolved
@mamy-CS
change post to get
83e79dc 
Signed-off-by: MohammedAbdi <[email protected]>
maia-iyer
maia-iyer approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Mohammed!

@mamy-CS mamy-CS merged commit 14c5d4b into dev Sep 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maia-iyer maia-iyer maia-iyer approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb lumjjb is a code owner

@mrsabath mrsabath Awaiting requested review from mrsabath mrsabath is a code owner

Assignees

@mamy-CS mamy-CS

Labels
enhancement New feature or request frontend Tornjak UI (Frontend)
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Update Frontend to use Tornjak v1 API
2 participants
@mamy-CS @maia-iyer