Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for extra audiences in JWT SVID #213

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

eminwux
Copy link
Contributor

@eminwux eminwux commented Nov 11, 2024

fixes #212

@faisal-memon
Copy link
Collaborator

faisal-memon commented Nov 12, 2024

Thanks @eminwux for this. Changes look good. Can you update the readme jwt_svids section to mention this new configurable? Also fix DCO.

@faisal-memon faisal-memon added this to the 0.9.0 milestone Nov 12, 2024
@faisal-memon faisal-memon self-assigned this Nov 12, 2024
...

Signed-off-by: Emiliano Spinella <[email protected]>
@eminwux eminwux marked this pull request as ready for review November 12, 2024 09:00
@eminwux
Copy link
Contributor Author

eminwux commented Nov 12, 2024

Hi @faisal-memon, I updated the readme with the new configurable. Also, I fixed the DCO. Let me know if there is anything else I should correct. Thank you!

@faisal-memon faisal-memon merged commit f4872f1 into spiffe:main Nov 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for extra audiences in JWT SVIDs
2 participants