Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to configure file permissions of written files (closes #183) #184

Merged
merged 26 commits into from
Sep 18, 2024
Merged

Add ability to configure file permissions of written files (closes #183) #184

merged 26 commits into from
Sep 18, 2024

Conversation

keeganwitt
Copy link
Contributor

@keeganwitt keeganwitt commented Sep 11, 2024 •
edited by faisal-memon
Loading

fixes #183

@keeganwitt keeganwitt force-pushed the configurable-file-permissions branch 3 times, most recently from 408adcd to 561b813 Compare September 11, 2024 15:34
@faisal-memon
Copy link
Collaborator

Thanks @keeganwitt. Some unit tests are failing.

@keeganwitt
Copy link
Contributor Author

Thanks @keeganwitt. Some unit tests are failing.

I saw that, but didn't understand why.

--- FAIL: TestNewSidecarConfig (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xd8 pc=0xb0ff4d]

@faisal-memon faisal-memon added this to the 0.9.0 milestone Sep 11, 2024
@keeganwitt
Copy link
Contributor Author

keeganwitt commented Sep 11, 2024 •
edited
Loading

Thanks @keeganwitt. Some unit tests are failing.

I saw that, but didn't understand why.

--- FAIL: TestNewSidecarConfig (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xd8 pc=0xb0ff4d]

Never mind. I think I figured it out.

@keeganwitt keeganwitt force-pushed the configurable-file-permissions branch 3 times, most recently from 9aa93c6 to d7036a4 Compare September 11, 2024 20:23
@keeganwitt keeganwitt force-pushed the configurable-file-permissions branch 3 times, most recently from f6aa208 to 5a7a807 Compare September 12, 2024 01:32
@keeganwitt keeganwitt force-pushed the configurable-file-permissions branch 9 times, most recently from c7e5eba to 464bf75 Compare September 13, 2024 22:28
faisal-memon
faisal-memon reviewed Sep 17, 2024
View reviewed changes
pkg/sidecar/config.go Outdated Show resolved Hide resolved
keeganwitt and others added 12 commits September 17, 2024 13:41
@keeganwitt @faisal-memon
Update pkg/sidecar/config.go
790e7b1 
Co-authored-by: Faisal Memon <[email protected]>
Signed-off-by: Keegan Witt <[email protected]>
@keeganwitt @faisal-memon
Update pkg/sidecar/sidecar.go
04fdc67 
Co-authored-by: Faisal Memon <[email protected]>
Signed-off-by: Keegan Witt <[email protected]>
@keeganwitt @faisal-memon
Update pkg/sidecar/sidecar.go
9789401 
Co-authored-by: Faisal Memon <[email protected]>
Signed-off-by: Keegan Witt <[email protected]>
@keeganwitt @faisal-memon
Update pkg/sidecar/workloadapi.go
8535e1b 
Co-authored-by: Faisal Memon <[email protected]>
Signed-off-by: Keegan Witt <[email protected]>
@keeganwitt @faisal-memon
Update cmd/spiffe-helper/config/config.go
98db7fe 
Co-authored-by: Faisal Memon <[email protected]>
Signed-off-by: Keegan Witt <[email protected]>
@keeganwitt @faisal-memon
Update cmd/spiffe-helper/config/config.go
575844b 
Co-authored-by: Faisal Memon <[email protected]>
Signed-off-by: Keegan Witt <[email protected]>
@keeganwitt @faisal-memon
Update pkg/sidecar/workloadapi.go
8dafb32 
Co-authored-by: Faisal Memon <[email protected]>
Signed-off-by: Keegan Witt <[email protected]>
@keeganwitt
Fix casing
6b7bca5 
Signed-off-by: Keegan Witt <[email protected]>
@keeganwitt
Fix casing
771d2ad 
Signed-off-by: Keegan Witt <[email protected]>
@keeganwitt
go fmt
3a4bee4 
Signed-off-by: Keegan Witt <[email protected]>
@keeganwitt
Move defaulting logic to ValidateConfig
f8fecf6 
Signed-off-by: Keegan Witt <[email protected]>
@keeganwitt
Ignore linting errors
35756fc 
Signed-off-by: Keegan Witt <[email protected]>
faisal-memon
faisal-memon reviewed Sep 18, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@faisal-memon
Copy link
Collaborator

faisal-memon commented Sep 18, 2024 •
edited
Loading

Thanks @keeganwitt for making the changes, just one last change needed to align the tables in the readme.

@keeganwitt @faisal-memon
Update README.md
c7b4625 
Co-authored-by: Faisal Memon <[email protected]>
Signed-off-by: Keegan Witt <[email protected]>
@keeganwitt
Copy link
Contributor Author

Thanks @keeganwitt for making the changes, just one last change needed to align the tables in the readme.

Looks like your change for that was correct.

faisal-memon
faisal-memon approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@faisal-memon faisal-memon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @keeganwitt

@faisal-memon faisal-memon merged commit b6b1642 into spiffe:main Sep 18, 2024
13 checks passed
@keeganwitt keeganwitt deleted the configurable-file-permissions branch September 19, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faisal-memon faisal-memon faisal-memon approved these changes

@MarcosDY MarcosDY Awaiting requested review from MarcosDY MarcosDY is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

SVIDs are not readable by containers running as a different user
2 participants
@keeganwitt @faisal-memon