Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit 0 on SIGTERM #180

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Exit 0 on SIGTERM #180

merged 2 commits into from
Sep 11, 2024

Conversation

faisal-memon
Copy link
Collaborator

Exit gracefully on SIGTERM. SIGTERM is used for a normal exit in kubernetes. See linked issue.

fixes #179

Signed-off-by: Faisal Memon <[email protected]>
Copy link
Contributor

@kfox1111 kfox1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! :)

@faisal-memon faisal-memon added this to the 0.8.0 milestone Sep 5, 2024
@faisal-memon faisal-memon merged commit f365fcb into main Sep 11, 2024
13 checks passed
@faisal-memon faisal-memon deleted the sigterm branch September 11, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spiffe-helper as a native sidecar doesn't exit with code 0 when main container exits
4 participants