Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix federated config #167

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Fix federated config #167

merged 3 commits into from
Jul 1, 2024

Conversation

faisal-memon
Copy link
Collaborator

Forgot to set IncludeFederatedDomains when doing the reorg in #146

Signed-off-by: Faisal Memon <[email protected]>
Copy link
Collaborator

@MarcosDY MarcosDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but can you add some documentation about this new configurable?

@faisal-memon
Copy link
Collaborator Author

looks good, but can you add some documentation about this new configurable?

@MarcosDY Its already part of the readme: https://github.com/spiffe/spiffe-helper/blob/main/README.md?plain=1#L35

@MarcosDY MarcosDY merged commit fc54f46 into main Jul 1, 2024
13 checks passed
@MarcosDY MarcosDY deleted the fix-federated-bundle branch July 1, 2024 18:56
@faisal-memon faisal-memon added this to the 0.8.0 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants