-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve settings dialog #792
feat: improve settings dialog #792
Conversation
…ry/marketplace into redesign-settings-dialog
The entire marketplace is being overhauled, might be able to apply these changes when it's made public though |
He's aware of v3. |
Yeah I know, but i'd already implemented most of it so i figured i'd just open the PR I can recreate it in v3 if wanted |
@zhngharry In that case I'd be down to merge as long as @theRealPadster is as well, up to everyone else if they want a new release for it and such though. |
I'm down to merge it, I don't see any harm in some final QOL updates before v3 |
Could we add some text to explain that you can click to disable them? It's not obvious. Maybe something like "drag and drop to reorder, click to toggle on and off" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, thanks!
Based on #465
Improves the settings dialog CSS and turn tab order settings into draggable list.
A user can hide a tab when clicking on it, reordering is done via drag and drop
Before:
After: