Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve settings dialog #792

Merged
merged 19 commits into from
Jul 7, 2024

Conversation

zhngharry
Copy link
Contributor

@zhngharry zhngharry commented Jun 24, 2024

Based on #465

Improves the settings dialog CSS and turn tab order settings into draggable list.
A user can hide a tab when clicking on it, reordering is done via drag and drop

Before:
image

After:
image

@zhngharry zhngharry requested a review from a team as a code owner June 24, 2024 16:11
@zhngharry zhngharry requested review from CharlieS1103 and removed request for a team June 24, 2024 16:11
@zhngharry zhngharry marked this pull request as draft June 25, 2024 16:57
@zhngharry zhngharry marked this pull request as ready for review July 1, 2024 15:00
@CharlieS1103
Copy link
Member

The entire marketplace is being overhauled, might be able to apply these changes when it's made public though

@rxri
Copy link
Member

rxri commented Jul 4, 2024

The entire marketplace is being overhauled, might be able to apply these changes when it's made public though

He's aware of v3.

@zhngharry
Copy link
Contributor Author

The entire marketplace is being overhauled, might be able to apply these changes when it's made public though

Yeah I know, but i'd already implemented most of it so i figured i'd just open the PR

I can recreate it in v3 if wanted

@CharlieS1103
Copy link
Member

@zhngharry In that case I'd be down to merge as long as @theRealPadster is as well, up to everyone else if they want a new release for it and such though.

@theRealPadster
Copy link
Member

I'm down to merge it, I don't see any harm in some final QOL updates before v3

@theRealPadster
Copy link
Member

Could we add some text to explain that you can click to disable them? It's not obvious. Maybe something like "drag and drop to reorder, click to toggle on and off"

@theRealPadster theRealPadster self-requested a review July 6, 2024 20:34
@theRealPadster theRealPadster added the 💫 enhancement New feature or request label Jul 6, 2024
@theRealPadster theRealPadster linked an issue Jul 7, 2024 that may be closed by this pull request
@zhngharry
Copy link
Contributor Author

Looks like this now

image

Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks!

@theRealPadster theRealPadster merged commit b625280 into spicetify:main Jul 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💫 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign Settings dialog
4 participants