Do not perform any timezone conversions if SOURCE_DATE_EPOCH is set #13203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
reviewed
Jan 2, 2025
AA-Turner
added
type:enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Do not perform any timezone conversions if SOURCE_DATE_EPOCH is set
Feature or Bugfix
Detail
Since PR #12907, various packages which use Sphinx stopped passing reproducibility test in Debian. In that test, we try to build the package in various environments (which includes varying the time zone), and make sure that the output is byte-to-byte identical.
However, that PR made
html_last_updated_time_zone == "local"by default, which means the generated output depends on the time zone the package is built in. To solve this problem, I propose to not do any timezone conversion whenSOURCE_DATE_EPOCHis set. When that variable is set, people most likely want a reproducible result, which should not depend on the time zone.Relates