Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access cursor before closing the db connection #19

Merged
merged 1 commit into from
May 14, 2024
Merged

Access cursor before closing the db connection #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sphinxcontrib/sqltable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ def run(self):
LOG.info('Running query %r' % query)
with engine.connect() as conn:
results = conn.execute(sqlalchemy.text(query))
table_headers = results.keys()
table_body = results.fetchall()
except Exception as err:
error = self.state_machine.reporter.error(
u'Error with query %s for sqltable: %s' % (
Expand All @@ -83,8 +85,6 @@ def run(self):
return [error]

# Extract some values we need for building the table.
table_headers = results.keys()
table_body = results
max_cols = len(table_headers)

# Handle the width settings and title
Expand Down
Loading