-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build-system dependencies #80
base: master
Are you sure you want to change the base?
Conversation
…depends. Remove python-setuptools-scm-git-archive from makedepends by applying upstreamed patch: sphinx-contrib/sphinxcontrib-towncrier#80 git-svn-id: file:///srv/repos/svn-community/svn@1382179 9fca08f4-af9d-4005-b8df-a31f2cc04f65
…depends. Remove python-setuptools-scm-git-archive from makedepends by applying upstreamed patch: sphinx-contrib/sphinxcontrib-towncrier#80 git-svn-id: file:///srv/repos/svn-community/svn@1382179 9fca08f4-af9d-4005-b8df-a31f2cc04f65
This will probably need to wait until I drop Python 3.6. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 64.63% 64.63%
=======================================
Files 14 14
Lines 246 246
Branches 30 30
=======================================
Hits 159 159
Misses 86 86
Partials 1 1 |
I didn't even notice you still support 3.6. Is there a reason for it? After all, upstream already EOL'd it :) |
I usually don't rush to drop support if there's no compelling reason to do so. Especially, in small projects, where it takes more effort than just leaving it as is. Plus, in this project it is much more important to work on adding the integration tests to improve the coverage and be able to stop shipping only alpha versions, plus use a better trove classifier for stability. FWIW, from the Python packaging perspective, I declare minimum versions with the software features needed and then, it works with the newer versions too. Bumping the lower bound doesn't seem justified right now. Re:patch — I think, that it could be acceptable now if instead of replacing the entries it made use of env markers to have them as is for Python 3.6 and only add the updated deps for Python 3.7+ (just 7.0). Note that setuptools-scm 7+ no longer declares the |
pyproject.toml: Update setuptools-scm to >= 7.1.0 to drop the requirement for setuptools-scm-git-archive (since the functionality is included since 7.0.0). Update requirement for setuptools accordingly.
37de362
to
2fcfcb2
Compare
pyproject.toml:
Update setuptools-scm to >= 7.1.0 to drop the requirement for setuptools-scm-git-archive (since the functionality is included since 7.0.0).
Update requirement for setuptools accordingly.