Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the vscode folder #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

12rambau
Copy link
Member

I've been asked to remove this folder in every project I've been working in. I thinks it's a good habit to avoid IDE related configuration files.

@lcnittl
Copy link
Member

lcnittl commented Dec 19, 2023

I thinks it's a good habit to avoid IDE related configuration files.

I think it is a matter of taste, and there are certainly cases where having IDE related config files under SCM is beneficial. However, I agree that in this case there is no real benefit (though, also not really any disadvantage).

I disagree though with the proposed change to .gitignore

@12rambau
Copy link
Member Author

this file is the default .gitignore file for Python used in github: https://github.com/github/gitignore/blob/main/Python.gitignore
it includes some IDE management files for both pycharm and jupyterLab so my understanding is that it's good practice.
If removing .vscode from SCM is ok for you why adding it in .gitignore is a problem ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants