Skip to content

Commit

Permalink
fix: apply envPrefix to all BindEnv vars
Browse files Browse the repository at this point in the history
  • Loading branch information
justintoman committed Jun 26, 2024
1 parent e71d7bf commit e4d50ca
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 1 deletion.
6 changes: 5 additions & 1 deletion viper.go
Original file line number Diff line number Diff line change
Expand Up @@ -1106,7 +1106,11 @@ func (v *Viper) BindEnv(input ...string) error {
if len(input) == 1 {
v.env[key] = append(v.env[key], v.mergeWithEnvPrefix(key))
} else {
v.env[key] = append(v.env[key], input[1:]...)
envKeys := make([]string, len(input[:1]))
for i, envKey := range input[1:] {
envKeys[i] = v.mergeWithEnvPrefix(envKey)
}
v.env[key] = append(v.env[key], envKeys...)
}

return nil
Expand Down
24 changes: 24 additions & 0 deletions viper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2590,6 +2590,30 @@ func TestFlagShadow(t *testing.T) {
assert.Equal(t, "", v.GetString("foo.bar1.bar2"))
}

func TestBindUsesEnvPrefix(t *testing.T) {
v := New()

os.Setenv("APP_FOO", "foo")
os.Setenv("APP_BAR", "bar")

v.SetEnvPrefix("APP")
v.AutomaticEnv()
v.BindEnv("foo1", "FOO")
v.BindEnv("bar1", "BAR")

assert.Equal(t, "foo", v.Get("foo1"))
assert.Equal(t, "bar", v.Get("bar1"))

type TestStruct struct {
Foo1 string `mapstructure:"foo1"`
Bar1 string `mapstructure:"bar1"`
}
var ts TestStruct
assert.NoError(t, v.Unmarshal(&ts))
assert.Equal(t, "foo", ts.Foo1)
assert.Equal(t, "bar", ts.Bar1)
}

func BenchmarkGetBool(b *testing.B) {
key := "BenchmarkGetBool"
v = New()
Expand Down

0 comments on commit e4d50ca

Please sign in to comment.