CNX-619 Revit Analytical Panel

[bjoernsteinhagen]

Description & Motivation

• Element2D (from Objects.Structural.Geometry.Element2D) was not being received in a meaningful way in ETABS
  • The objects were created in ETABS, but all properties were set to Slab1 (the first property in the list of predefined properties in a new model)
  • Element2D is part of the Structural kit, therefore, in a structural analysis software, at least some of the attributes (e.g. thickness and material) should be recievable
  • In a large building with many different properties and materials, defaulting everything to a single property leaves the User with lots of post-receiving editing to do -> not cool.

• In order to use the Element2D, an issue with the property and material attributes of an Element2D coming from Revit was also noted. All of these values remained in the Revit internal units presenting a dissociation from the ModelUnits.

• Finally, consider Grasshopper: a Property2D component can serve as input to the CSIElement2D component. However, upon receiving in ETABS this will be handled as a generic Slab1 element.

Changes:

• Numeric values associated with Element2D, Property2D and StructuralMaterial implemented ScaleToSpeckle() when sending from Revit. Previously Revit internal units were provided. Scalings for stress and mass density parameters was also included for consistency.
• The physical association (displayValue) for Revit version < 2023 was fixed, previously the 2D planar surface was displayed and not the 3D mesh of the associated physical element (done for Revit versions >= 2023 and for the Element1D of versions < 2023)
• CSIConverter was updated to handle AreaToNative() not just for properties of type CSIProperty2D but also for Property2D

Validation of changes:

• The connection Revit to ETABS was tested extensively. Properties of Element2D appropriately converted (floors and walls) and can be seen in the following streams:
  • Revit 2022 to Speckle: https://latest.speckle.systems/projects/124c798574/models/4339ac02bd
  • Revit 2023 to Speckle: https://latest.speckle.systems/projects/124c798574/models/f4b18d4b2d
  • Revit 2024 to Speckle: https://latest.speckle.systems/projects/124c798574/models/e953102b93
• Models being received appropriately in ETABS, see full list of different properties created with appropriate thicknesses. Note the following:
  • Slab and wall sections created and in appropriate sections! Previously, all 2D elements were assigned to slab sections (walls too)
  • The material assert name gets used to search for an appropriate material from the ETABS Database, if no match, defaults to the model region default
  • Thickness parameter works for test cases (Revit model in mm to ETABS model in m etc. etc.)
    

Checklist:

• My pull request follows the guidelines in the Contributing guide?
• My pull request does not duplicate any other open Pull Requests for the same update/change?
• My commits are related to the pull request and do not amend unrelated code or documentation.
• My code follows a similar style to existing code.
• I have added appropriate tests.
• I have updated or added relevant documentation.

[linear]

CNX-619 Revit AnalyticalPanel to ETABS

[bjoernsteinhagen]

isPropertyHandled is a more appropriate name than isExactMatch

[bjoernsteinhagen]

ConvertAnalyticalSurface was using a method of GetStructuralMaterial which is inside ConvertAnalyticalStick (?). ConvertStructuralMaterial includes material related functions and these were moved out of ConvertAnalyticalStick.cs

[bjoernsteinhagen]

Now, the method will only return Slab1 (from propNames.First() if:

• The property does not already exist in the model (propNames.Contains(property?.name) is false)
• It's not a CSI property that can be converted successfully
• It's not a Property2D with a non-empty name that can be converted successfully
• There are property names in the propNames array