a couple of random FE2 fixes reported on Discord (#1943)

* fix(fe2): clearer error msg on failed upload * fix(fe2): missing project.commentThreads access w/ admin override
specklesystems · Jan 8, 2024 · a563fa2 · a563fa2
1 parent 36f749b
commit a563fa2
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/packages/frontend-2/components/project/CardImportFileArea.vue b/packages/frontend-2/components/project/CardImportFileArea.vue
@@ -23,7 +23,7 @@
           v-if="errorMessage"
           class="text-danger inline-flex space-x-1 items-center text-center"
         >
-          <ExclamationTriangleIcon class="h-4 w-4" />
+          <ExclamationTriangleIcon class="h-4 w-4 shrink-0" />
           <span>{{ errorMessage }}</span>
         </span>
         <div

diff --git a/packages/frontend-2/lib/core/api/fileImport.ts b/packages/frontend-2/lib/core/api/fileImport.ts
@@ -51,6 +51,16 @@ export function importFile(
   })
 
   request.addEventListener('load', () => {
+    if (!request.response) {
+      return rejectResponse(
+        new Error(
+          `Upload failed${
+            request.status ? ' with code ' + request.status : ''
+          } - no response`
+        )
+      )
+    }
+
     const uploadResults =
       (request.response as Optional<PostBlobResponse>)?.uploadResults || []
     const result = uploadResults.find((r) => r.formKey === formKey)

diff --git a/packages/server/modules/comments/services/management.ts b/packages/server/modules/comments/services/management.ts
@@ -39,6 +39,7 @@ import {
   formatSerializedViewerState,
   inputToDataStruct
 } from '@/modules/comments/services/data'
+import { adminOverrideEnabled } from '@/modules/shared/helpers/envHelper'
 
 export async function authorizeProjectCommentsAccess(params: {
   projectId: string
@@ -60,6 +61,7 @@ export async function authorizeProjectCommentsAccess(params: {
   if (!project.isPublic && !project.role) success = false
   if (requireProjectRole && !project.role && !project.allowPublicComments)
     success = false
+  if (adminOverrideEnabled() && authCtx.role === Roles.Server.Admin) success = true
 
   if (!success) {
     throw new StreamInvalidAccessError('You are not authorized')