Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Japanese translation #1141

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Japanese translation #1141

wants to merge 8 commits into from

Conversation

koizumistr
Copy link

No description provided.

koizumistr and others added 7 commits October 21, 2024 23:30
@bact bact added the translation: ja Translation for Japanese language label Oct 22, 2024
@bact
Copy link
Collaborator

bact commented Oct 25, 2024

The addition of translated files are looking good.

The only warning, which made the check failed, is about the inclusion of those files in nav section of mkdocs.yml.
This needs more discussion later on how we like to deal with it (it is likely that we may need one MkDocs configuration per one language?)
But for now I think this PR is good to merge (and we can improve upon afterward). The translation files themselves are good.

The only question I have in mind now is which branch this PR should merge to?

@koizumistr koizumistr mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
translation: ja Translation for Japanese language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koizumistr @bact @AWatanabe418 @nao027