Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow usage of non-default copyManager in JacksonDeSerializer #76

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Allow usage of non-default copyManager in JacksonDeSerializer #76

merged 3 commits into from
Nov 7, 2024

Conversation

martin-bpw
Copy link
Contributor

No description provided.

@martin-bpw
Copy link
Contributor Author

Draft proposal #75

@goneall
Copy link
Member

goneall commented Nov 7, 2024

Thanks @martin-bpw - I'll take a look later today - but the approach seems resonable.

goneall
goneall reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is missing the import statement JacksonDeSerializer:

import org.spdx.core.IModelCopyManager;

and in the MultiFormatStore:

import org.spdx.library.ModelCopyManager;

src/main/java/org/spdx/jacksonstore/JacksonDeSerializer.java Show resolved Hide resolved
goneall
goneall approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @martin-bpw

@goneall goneall merged commit 9b34e44 into spdx:master Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martin-bpw @goneall @prodial