Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create build profile example-1 #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lumjjb
Copy link
Contributor

@lumjjb lumjjb commented Jul 5, 2024

took a stab at creating a build profile example, based on my understanding of the model and serialization.

@kestewart

@kestewart
Copy link
Contributor

Waiting until the CI is updated, then we'll take a pass.

@kestewart kestewart self-requested a review August 20, 2024 16:57
@kestewart
Copy link
Contributor

@lumjjb - can you rebase and see if you can get it passing the validation. Once it is, we'll merge.

@goneall
Copy link
Member

goneall commented Sep 12, 2024

Attached is an updated examples that almost passes validation using the 3.0.1 spec.

It passes my Java verification code (generated from the 3.0.1 schema), but doesn't pass the schema validation.

I'm not quite sure why it is failing the schema validation. Here's a link to the 3.0.1 schema I'm using for validation: https://spdx.github.io/spdx-spec/v3.0.1/rdf/schema.json

@JPEWdev - if you get a chance, can you try the attached on your validation tools and see if you get any insights.
example1.json.txt

@goneall
Copy link
Member

goneall commented Sep 12, 2024

I figured out the validation issues - attached is a JSON file that will pass with the 3.0.1 schema file:
example1.json.txt

@JPEWdev
Copy link
Contributor

JPEWdev commented Sep 24, 2024

The spdx-validate tool needs to be updated for 3.0.1, then validation should pass. I'll change that and publish it.

@bact
Copy link
Contributor

bact commented Oct 11, 2024

spdx3-validate 0.0.4 is now supporting v3.0.1. We can try rerunning the validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants