Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Markdown headings used in spec generation #867

Merged
merged 24 commits into from
Nov 14, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Aug 28, 2024

Add a documentation about headings and formatting used in Markdown files for the specification generation.

This will allow contributors to better familiarise with the format that is expected from the spec-parser.

If there is an update in the spec-parser, this document should be updated as well.

--

Current Table of contents:

  • Overview
  • Directory organisation
  • File content structure and formatting
    • Model file example
  • Syntax
    • Classes
    • Datatypes
    • Individuals
    • Properties
    • Vocabularies
  • Writing style
  • Localisation
    • Localisation example

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact added the documentation Improvements or additions to documentation label Aug 28, 2024
@bact bact added this to the 3.1 milestone Aug 28, 2024
@bact bact self-assigned this Aug 28, 2024
@bact
Copy link
Collaborator Author

bact commented Sep 4, 2024

@zvr @goneall does this document best to be inside this spdx-3-model repo or in the spec-parser repo?

I can open new PR in spec-parser if it is more preferred (and close this one here).

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact changed the title Add Markdown for SPDX spec generation documentation Add documentation for Markdown headings used in spec generation Sep 7, 2024
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @bact

zvr
zvr previously requested changes Sep 7, 2024
Copy link
Member

@zvr zvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we want to spend time trying to define everything.

We definitely need to also address multi-lingual content (maybe not right now, but in the future).

specmark.md Outdated Show resolved Hide resolved
specmark.md Outdated Show resolved Hide resolved
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested review from zvr and kestewart September 8, 2024 00:32
@goneall
Copy link
Member

goneall commented Sep 24, 2024

@zvr - Are you OK with merging this? From the tech call, we felt there was value in documenting this for those doing localization / internationalization for the model.

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we should leave a "Blah" in the text, but rest looks fine.

specmark.md Outdated Show resolved Hide resolved
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested a review from kestewart October 19, 2024 13:45
@zvr
Copy link
Member

zvr commented Oct 21, 2024

I'll review it in detail later this week, but it would be nice to define what our (long-term?) goal will be, @kestewart @goneall .

If we are to produce another PDF version, then my suggestion would be to limit the markdown that can be used, since currently I need to manually change some stuff to produce the PDF. If, on the other hand, we only care about the website (HTML version), then it's perfectly fine to leave "allow everything", as long as it renders fine.

From a quick look, we could add info on:

  • links (all have to have text, no bare URLs)
  • standardized formats (we have for RFCs, I don't remember whether there is already anything else)
  • other languages sections

bact and others added 3 commits November 4, 2024 15:43
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
The Japanese example in this documentation is by @NorioKobota

Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-Authored-By: Norio Kobota <[email protected]>
@bact
Copy link
Collaborator Author

bact commented Nov 6, 2024

All three additions suggested by @zvr is added:

@bact bact dismissed zvr’s stale review November 13, 2024 09:30

Suggestions already incorporated. Will made another request for review.

@bact bact requested review from zvr and removed request for zvr November 13, 2024 09:30
@zvr
Copy link
Member

zvr commented Nov 13, 2024

@bact a couple of suggestions:

  • change the filename, since it now suggests something about the SPEC benchmark ;-). Maybe format.md ?
  • separate the other-language stuff to translations.md
  • ideally we would like to have another doc describing our git branching strategy (not necessarily in this PR)

Maybe move everything to a DOCS subdirectory instead of top-level?

Also break Localisation section to translation.md

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Copy link
Collaborator Author

bact commented Nov 13, 2024

Thank you @zvr. I have updated the document, separating it to two files as suggested.

Also move them to a new docs/, together with few other docs.

@zvr
Copy link
Member

zvr commented Nov 14, 2024

We can merge this, and improve it later.

Still missing, for example: the file where translations will provide the headings in their own language. But I haven't fully worked it out yet, so no need to wait and block this.

@zvr zvr merged commit 19f5e53 into spdx:main Nov 14, 2024
1 check passed
@bact bact deleted the add-spec-markdown-docs branch November 14, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README and CONTRIBUTING with markdown format
4 participants