Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FsfLibre flag to GPL-2.0 #453

Closed
wants to merge 1 commit into from
Closed

Add FsfLibre flag to GPL-2.0 #453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GPL-2.0.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<SPDXLicenseCollection xmlns="http://www.spdx.org/license">
<license isOsiApproved="true" licenseId="GPL-2.0"
<license isOsiApproved="true" isFsfLibre="true" licenseId="GPL-2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I've said earlier, I'd much rather be pulling this from an FSF API. In the absence of such an API (the current situation) I think we should put this information in a mock FSF API which we can hand over to the FSF when they're ready to step up and maintain it. I really don't like baking other people's metadata into our root data repository. I would much rather this information be included in license-list-data after being pulled from the (mock) FSF API, instead of including the metadata here.

I am ok baking in an FSF license ID (if they decide to diverge from SPDX IDs in their API), at least until we address #418.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree in principle, but I don't want to screen scrape for the information. We could have a mock API that would work from a config file. It should present the data through a web API, preferably REST based

Copy link
Contributor

@wking wking Oct 20, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was imagining we dump some JSON into GitHub. I'll sketch that out tonight.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON works. If you put together sending side - I can update the SPDX license generator to use it.
@kestewart - Can you just put together a list of the licenses you think are FSF Libre?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll pull the list using JavaScript, as I showed on the mailing list.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goneall - sure. Just a flat text file of one SPDX-license-identifier per line for the subset that are isFsfLibre?

name="GNU General Public License v2.0 only">
<crossRefs>
<crossRef>http://www.gnu.org/licenses/old-licenses/gpl-2.0-standalone.html</crossRef>
Expand Down