V14 #17
Merged
V14 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
… notes (Shopify#3229) * Fix translation path (Shopify#3198) * Change product variant swatches' border color (Shopify#3204) * change color reference * remove character * increase to meet contrast ratio of 3 * Update swatch setting info text (Shopify#3205) * Update info text * remove duplication * add space * clean up language and association * add to second place * Update 9 translation files * Update 4 translation files * Update 6 translation files * Update 1 translation file --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (Shopify#3203) * Change the message when removing only one item from the QOL * Update 20 translation files * Update 6 translation files * Update 4 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Update 1 translation file (Shopify#3202) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * update version number and release notes --------- Co-authored-by: melissaperreault <[email protected]> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Eugene Kasimov <[email protected]>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
* Update README.md * fix url formatting --------- Co-authored-by: Ludo <[email protected]>
* Fix schema JSON formatting Co-authored-by: Abhishek Jani <[email protected]> * Add loading=eager attribute to gift card page img * Use liquid tag to combine successive liquid statements Co-authored-by: Abhishek Jani <[email protected]> * Remove snippet to avoid > 3 levels of nested snippets * Ignore AssetPreload theme check for font links --------- Co-authored-by: Abhishek Jani <[email protected]>
* Fix translation path (Shopify#3198) * Change product variant swatches' border color (Shopify#3204) * change color reference * remove character * increase to meet contrast ratio of 3 * Update swatch setting info text (Shopify#3205) * Update info text * remove duplication * add space * clean up language and association * add to second place * Update 9 translation files * Update 4 translation files * Update 6 translation files * Update 1 translation file --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (Shopify#3203) * Change the message when removing only one item from the QOL * Update 20 translation files * Update 6 translation files * Update 4 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Fix drawer stylings (Shopify#3248) * Update 1 translation file (Shopify#3202) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Pull update from release branch and update version number and release notes (Shopify#3229) * Fix translation path (Shopify#3198) * Change product variant swatches' border color (Shopify#3204) * change color reference * remove character * increase to meet contrast ratio of 3 * Update swatch setting info text (Shopify#3205) * Update info text * remove duplication * add space * clean up language and association * add to second place * Update 9 translation files * Update 4 translation files * Update 6 translation files * Update 1 translation file --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (Shopify#3203) * Change the message when removing only one item from the QOL * Update 20 translation files * Update 6 translation files * Update 4 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Update 1 translation file (Shopify#3202) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * update version number and release notes --------- Co-authored-by: melissaperreault <[email protected]> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Eugene Kasimov <[email protected]> * Update 1 translation file (Shopify#3232) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Fix cart drawer header background and cart note summary spacing * more cart drawer touch ups * remove some of the unwanted changes --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: melissaperreault <[email protected]> Co-authored-by: Eugene Kasimov <[email protected]> * fix missing alt tags for collection images (Shopify#3262) * Update titles (Shopify#3265) * Condense country selector width when there are no currencies (Shopify#3269) * Recreate existing PR based on the right branch (Shopify#3274) * Fix product review alignment when product doesn't have medias (Shopify#3264) * Fix product review alignment when product doesn't have medias * Add the escape to match with branch target * Touch up scroll into view PDP (Shopify#3276) * Fix mobile behaviour for scroll into view * remove conditions * remove unused data attribute (Shopify#3277) * Remove sticky header on cart drawer to avoid overlap of content (Shopify#3279) * fix scrolling scenario on mobile (Shopify#3286) * Update 1 translation file (Shopify#3202) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Pull update from release branch and update version number and release notes (Shopify#3229) * Fix translation path (Shopify#3198) * Change product variant swatches' border color (Shopify#3204) * change color reference * remove character * increase to meet contrast ratio of 3 * Update swatch setting info text (Shopify#3205) * Update info text * remove duplication * add space * clean up language and association * add to second place * Update 9 translation files * Update 4 translation files * Update 6 translation files * Update 1 translation file --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (Shopify#3203) * Change the message when removing only one item from the QOL * Update 20 translation files * Update 6 translation files * Update 4 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Update 1 translation file (Shopify#3202) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * update version number and release notes --------- Co-authored-by: melissaperreault <[email protected]> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Eugene Kasimov <[email protected]> * Update 1 translation file (Shopify#3232) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Update README.md (Shopify#3128) * Update README.md * fix url formatting --------- Co-authored-by: Ludo <[email protected]> * Fix Theme Check offences (Shopify#3283) * Fix schema JSON formatting Co-authored-by: Abhishek Jani <[email protected]> * Add loading=eager attribute to gift card page img * Use liquid tag to combine successive liquid statements Co-authored-by: Abhishek Jani <[email protected]> * Remove snippet to avoid > 3 levels of nested snippets * Ignore AssetPreload theme check for font links --------- Co-authored-by: Abhishek Jani <[email protected]> * update release notes --------- Co-authored-by: melissaperreault <[email protected]> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Eugene Kasimov <[email protected]> Co-authored-by: Renan Souza <[email protected]> Co-authored-by: Abdulrahman Hamideh <[email protected]> Co-authored-by: Benjamin Sehl <[email protected]> Co-authored-by: Kai <[email protected]> Co-authored-by: Abhishek Jani <[email protected]>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Additional changes Update styles PR fix Bring back disabled, just in case
* Switch swatch filters to use swatch API * Rename to facets__label
* Add basic functionality. Add placeholder. Make a row rerender instead of the whole section. * Style placeholder * Fix removeAll button * Remove comments and unnecessary code. * Remove debouncing. * Remove placeholder for input * Add selection on focus for inputs * Move eventListener to a parent element * Put debouncing back * Refactor switchVariants method * Refactor allInputs array * Remove unnecessary input placeholder * Fix typo * Refactor variants names * Remove unused prop * Put back prop 'name' for updateQuantity * Refactoring * [Quick Order List] Prevent selected inputs being covered by total bar or header (Shopify#3278) * Prevent input elements going under total bar or sticky header during keyboard navigation. * Fix a typo * Refactoring * Increase z-index for volume pricing popup * Fix conflicts after merge
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
* Update twitter icon to x logo. * Refine X logo * Update label and info text. * Remove strokes from icon, use currentColor * Update text strings to reflect Twitter's new name. * Update en.default.json * Update 20 translation files * Update 14 translation files * Update 4 translation files * Update 6 translation files * Update 5 translation files * Update 1 translation file --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
* Fix QOL for one variant product * Move total bar position logic inside an if condition
* Clean errors * Move cleanErrors() to onChange() * Move cleanErrors to make sure it runs when you click trach icon
* Add image filters and do UX tweaks for swatches * Andy PR changes * Change how default presentation is set
Removed no-JS requirement from the contribution guidelines Remove CSS and no-js-only HTML add JS class to <html> remove noscript css selectors Update README
* Changed price filter to use text input * Removed stepping and enabled all meta key inputs * Turned price filter into a snippet to remove duplicate code * Removed need for nbsp, added escape and apostrophe, slightly changed debounce delay * Retain focus in text inputs
Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
* Simplify featured product to use the same media gallery snippet as main-product, simplify product-media-gallery, simplify main-product Updated CSS to fix overflow issue on mobile browsers * Set images with the network response instead of by rendering hidden images * Removed unnecessary assignment * Update media refresh handling to minimize rerenders * Tweaks to fix JS error and modal content not updating when switching away from a variant with a featured image * Removed dead code * Update fallback selector
* Updated option value picker to use product_option_value.variant, update availability handling to rely on async variant pagination Removed old event handler, update buy-buttons to handle selected_variant undefined case Fix for cases where selected_or_first_available_variant is null Only pass variant if present Fix JS error where param wasn't being passed to callback Added support for duplicated option names in option value picker and swatches Fix misnamed function in quick order list Add parent option values to quick order list Fix JS error if active media is not found Fix mismatched unsubscriber function name * fix bad merge
…Shopify#3358) * Cut the keyboard navigation feature for mobile * Rename variable Co-authored-by: Sofia Matulis <[email protected]> * Change variant name --------- Co-authored-by: Sofia Matulis <[email protected]>
* Update 13 translation files * Update 2 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Sofia Matulis <[email protected]>
…pify#3402) * Remove left/right padding for transparent banner_box. * Fix padding on mobile as well.
Added optional chaining to setActiveMedia call
…pify#3429) * Add check to prevent errors if no feat. image exists * remove redundancy
JiaJasonLiu
requested review from
rlweb,
timmw,
jacob-horton and
david-sparklayer
jacob-horton
approved these changes
May 24, 2024
david-sparklayer
approved these changes
May 24, 2024
cm-sl
approved these changes
May 26, 2024
timmw
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Update the version of Dawn to v14.0.0 to be up to date with upstream (Shopify/dawn)
Visual impact on existing themes
Nothing
SparkLayer Test:
Checklist