Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0.0 #14

Merged
merged 37 commits into from
Nov 3, 2023

Merge branch 'main' of https://github.com/Shopify/dawn into 12.0.0

8066fc4
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

12.0.0 #14

Merge branch 'main' of https://github.com/Shopify/dawn into 12.0.0
8066fc4
Select commit
Loading
Failed to load commit list.
GitHub Actions / Theme Check Report succeeded Nov 3, 2023 in 2s

Theme Check Report

0 error(s), 18 warning(s) found

Details

Configuration

Actions Input

Name Value
theme_root .
flags (not provided)
version (not provided)

ThemeCheck Configuration

---
root: "."
require: []
include_categories: []
exclude_categories: []
ignore:
- node_modules/*
extends: :nothing
ConvertIncludeToRender:
  enabled: true
  ignore: []
LiquidTag:
  enabled: true
  ignore: []
  min_consecutive_statements: 5
MissingTemplate:
  enabled: true
  ignore: []
  ignore_missing: []
NestedSnippet:
  enabled: true
  ignore: []
  max_nesting_level: 3
RequiredLayoutThemeObject:
  enabled: true
  ignore: []
SpaceInsideBraces:
  enabled: true
  ignore: []
SyntaxError:
  enabled: true
  ignore: []
TemplateLength:
  enabled: false
  ignore: []
  max_length: 600
  exclude_schema: true
  exclude_stylesheet: true
  exclude_javascript: true
UnknownFilter:
  enabled: true
  ignore: []
UnusedAssign:
  enabled: true
  ignore: []
UnusedSnippet:
  enabled: true
  ignore: []
MatchingSchemaTranslations:
  enabled: true
  ignore: []
MatchingTranslations:
  enabled: false
  ignore: []
DefaultLocale:
  enabled: true
  ignore: []
TranslationKeyExists:
  enabled: true
  ignore: []
ValidHTMLTranslation:
  enabled: true
  ignore: []
ValidJson:
  enabled: true
  ignore: []
ValidSchema:
  enabled: true
  ignore: []
MissingRequiredTemplateFiles:
  enabled: true
  ignore: []
UndefinedObject:
  enabled: true
  ignore: []
  exclude_snippets: true
  config_type: :default
RequiredDirectories:
  enabled: true
  ignore: []
DeprecatedFilter:
  enabled: true
  ignore: []
DeprecateLazysizes:
  enabled: true
  ignore: []
DeprecateBgsizes:
  enabled: true
  ignore: []
MissingEnableComment:
  enabled: true
  ignore: []
ParserBlockingJavaScript:
  enabled: true
  ignore: []
ParserBlockingScriptTag:
  enabled: true
  ignore: []
AssetPreload:
  enabled: true
  ignore: []
AssetSizeJavaScript:
  enabled: false
  threshold_in_bytes: 10000
  ignore: []
AssetSizeCSS:
  enabled: false
  threshold_in_bytes: 100000
  ignore: []
AssetSizeCSSStylesheetTag:
  enabled: false
  threshold_in_bytes: 100000
  ignore: []
ImgWidthAndHeight:
  enabled: true
  ignore: []
RemoteAsset:
  enabled: true
  ignore: []
AssetUrlFilters:
  enabled: true
  ignore: []
ContentForHeaderModification:
  enabled: true
  ignore: []
ImgLazyLoading:
  enabled: true
  ignore: []
HtmlParsingError:
  enabled: true
  ignore: []
AssetSizeAppBlockJavaScript:
  enabled: false
  ignore: []
  threshold_in_bytes: 10000
AssetSizeAppBlockCSS:
  enabled: false
  ignore: []
  threshold_in_bytes: 100000
AppBlockValidTags:
  enabled: false
  ignore: []
PaginationSize:
  enabled: true
  ignore: []
  min_size: 1
  max_size: 50
DeprecatedGlobalAppBlockType:
  enabled: true
SchemaJsonFormat:
  enabled: true
  start_level: 0
  indent: "  "

Annotations

Check warning on line 178 in layout/password.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

layout/password.liquid#L178

[AssetPreload] For better performance, prefer using the preload_tag filter

Check warning on line 181 in layout/password.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

layout/password.liquid#L181

[AssetPreload] For better performance, prefer using the preload_tag filter

Check warning on line 385 in layout/theme.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

layout/theme.liquid#L385

[LiquidTag] Use {% liquid ... %} to write multiple tags

Check warning on line 257 in layout/theme.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

layout/theme.liquid#L257

[AssetPreload] For better performance, prefer using the preload_tag filter

Check warning on line 260 in layout/theme.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

layout/theme.liquid#L260

[AssetPreload] For better performance, prefer using the preload_tag filter

Check notice on line 204 in sections/featured-blog.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/featured-blog.liquid#L204

[SchemaJsonFormat] JSON formatting could be improved

Check warning on line 80 in sections/featured-collection.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/featured-collection.liquid#L80

[LiquidTag] Use {% liquid ... %} to write multiple tags

Check warning on line 444 in sections/featured-product.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/featured-product.liquid#L444

[LiquidTag] Use {% liquid ... %} to write multiple tags

Check warning on line 145 in sections/main-collection-product-grid.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/main-collection-product-grid.liquid#L145

[LiquidTag] Use {% liquid ... %} to write multiple tags

Check warning on line 239 in sections/main-collection-product-quick-buy.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/main-collection-product-quick-buy.liquid#L239

[LiquidTag] Use {% liquid ... %} to write multiple tags

Check warning on line 436 in sections/main-product.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/main-product.liquid#L436

[LiquidTag] Use {% liquid ... %} to write multiple tags

Check warning on line 83 in sections/predictive-search.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/predictive-search.liquid#L83

[LiquidTag] Use {% liquid ... %} to write multiple tags

Check warning on line 36 in sections/related-products.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

sections/related-products.liquid#L36

[LiquidTag] Use {% liquid ... %} to write multiple tags

Check warning on line 24 in snippets/header-drawer.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

snippets/header-drawer.liquid#L24

[LiquidTag] Use {% liquid ... %} to write multiple tags

Check warning on line 10 in snippets/header-dropdown-menu.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

snippets/header-dropdown-menu.liquid#L10

[LiquidTag] Use {% liquid ... %} to write multiple tags

Check warning on line 10 in snippets/header-mega-menu.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

snippets/header-mega-menu.liquid#L10

[LiquidTag] Use {% liquid ... %} to write multiple tags

Check warning on line 95 in templates/gift_card.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

templates/gift_card.liquid#L95

[AssetPreload] For better performance, prefer using the preload_tag filter

Check warning on line 98 in templates/gift_card.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

templates/gift_card.liquid#L98

[AssetPreload] For better performance, prefer using the preload_tag filter

Check warning on line 138 in templates/gift_card.liquid

See this annotation in the file changed.

@github-actions github-actions / Theme Check Report

templates/gift_card.liquid#L132-L138

[ImgLazyLoading] Use loading="eager" for images visible in the viewport on load and loading="lazy" for others